🐛 make all imports explicit #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
direct imports are just for clarity. |
enryH
pushed a commit
to RasmussenLab/pimms
that referenced
this pull request
Jun 7, 2024
underlying case is polars import in mrmr-selection, see: RasmussenLab/njab#13
enryH
pushed a commit
to RasmussenLab/pimms
that referenced
this pull request
Jun 10, 2024
- make all import explicit - let workflow run as a last resort with one job at a time (although it wasn't necessary for the merge run) * 🐛 make all imports explicit w.r.t. to pkg * 📝 update M1 installation instructions - still does not seem to work * 🐛 deactivating njab makes it run! - committed from marc's M1 laptop * ⏪ use njab after fix in downstream pkg underlying case is polars import in mrmr-selection, see: RasmussenLab/njab#13 * 🐛 try to allow parallel installations for R - ubuntu runs are regularly failing as lock can cause issues - alternatively one job at a time could be run in the retry * 🐛 try to manuelly add missing dependency: gmm * ⚡📝 make ci more robust to installation issues, update README for Mac M1 chicps --------- Co-authored-by: mpielies <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue for M1 Macs is polars, which needs to use the arm instructions. Apparently M1 Macs can use two versions of instructions, but the details are a bit misterious. Anyways
In
mrmr-selectionthe lineleads to
zsh: illegal hardware instruction.see here
The current workaround for upstream packages using njab (like pimms-learn) is to only import mrmr-selection once it is needed...